ActualHorse/CarmenSandiego
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Final round often counts multiple correct responses with one marker #22

New Issue
Closed
opened 2025-07-17 00:27:55 -04:00 by ActualHorse · 1 comment
ActualHorse commented 2025-07-17 00:27:55 -04:00
Owner
Copy Link

There's clearly another small sync issue with the final round causing multiple valid "Correct Response" events to fire despite only one marker being placed. This should be investigated, because it seems more than just a bit rare.

There's clearly another small sync issue with the final round causing multiple valid "Correct Response" events to fire despite only one marker being placed. This should be investigated, because it seems more than just a bit rare.
ActualHorse added this to the v0.5 milestone 2025-07-17 00:27:55 -04:00
ActualHorse added the
Type
Bug
Priority
A
 labels 2025-07-17 00:27:55 -04:00
ActualHorse self-assigned this 2025-07-17 00:27:55 -04:00
ActualHorse commented 2025-07-20 20:43:34 -04:00
Author
Owner
Copy Link

This took far too long to figure out. Essentially we now check to make sure the local player matches the owner of the marker, and if so, only then do we send the event. This ensures the event can only fire one time in total. By doing this, everything stays in sync properly, and only one signal is ever fired to the owner of the GameManagerRound3 object.

I'm so happy this is finally done.

This took far too long to figure out. Essentially we now check to make sure the local player matches the owner of the marker, and if so, only then do we send the event. This ensures the event can only fire one time in total. By doing this, everything stays in sync properly, and only one signal is ever fired to the owner of the GameManagerRound3 object. I'm so happy this is finally done.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Priority
A
The priority is critical
Priority
B
The priority is high
Priority
C
The priority is medium
Priority
D
The priority is low
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Type
Breaking
Breaking change that won't be backward compatible
Type
Bug
Something is not working
Type
Documentation
Documentation changes
Type
Enhancement
Improve existing functionality
Type
Feature
New functionality
Type
Security
This is security issue
Type
Testing
Issue or pull request related to testing
No Label
Priority
A
Type
Bug
Milestone
No items
No Milestone v0.5
Projects
Clear projects
No project
Assignees
Clear assignees
ActualHorse
No Assignees ActualHorse
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ActualHorse/CarmenSandiego#22
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?