ActualHorse/CarmenSandiego
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Video player seems to need to load video indices unnecessarily in order to sync. #66

New Issue
Open
opened 2026-03-12 04:21:11 -04:00 by ActualHorse · 0 comments
ActualHorse commented 2026-03-12 04:21:11 -04:00
Owner
Copy Link

_ReloadVideoList() in the CaseVideoSyncPlayer class has a check to load a new video if the index is different from what was in its cache. Since this code is always run just before SetVideoIndex(), this seems like it shouldn't be necessary. It might be possible that since both functions end with RequestSerialization(), it's causing some kind of conflict or desync. Look into reducing the number of serialisation requests to make this code actually superfluous.

_ReloadVideoList() in the CaseVideoSyncPlayer class has a check to load a new video if the index is different from what was in its cache. Since this code is always run just before SetVideoIndex(), this seems like it shouldn't be necessary. It might be possible that since both functions end with RequestSerialization(), it's causing some kind of conflict or desync. Look into reducing the number of serialisation requests to make this code actually superfluous.
ActualHorse added this to the v0.5 milestone 2026-03-12 04:21:11 -04:00
ActualHorse added the
Type
Enhancement
Priority
A
 labels 2026-03-12 04:21:11 -04:00
ActualHorse self-assigned this 2026-03-12 04:21:11 -04:00
ActualHorse pinned this 2026-03-12 04:30:36 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Priority
A
The priority is critical
Priority
B
The priority is high
Priority
C
The priority is medium
Priority
D
The priority is low
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Type
Breaking
Breaking change that won't be backward compatible
Type
Bug
Something is not working
Type
Documentation
Documentation changes
Type
Enhancement
Improve existing functionality
Type
Feature
New functionality
Type
Security
This is security issue
Type
Testing
Issue or pull request related to testing
No Label
Priority
A
Type
Enhancement
Milestone
No items
No Milestone v0.5
Projects
Clear projects
No project
Assignees
Clear assignees
ActualHorse
No Assignees ActualHorse
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ActualHorse/CarmenSandiego#66
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?