ActualHorse/CarmenSandiego
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

CaseVideoSyncPlayer can cause an exception when loading map images #73

New Issue
Closed
opened 2026-04-17 14:58:35 -04:00 by ActualHorse · 2 comments
ActualHorse commented 2026-04-17 14:58:35 -04:00
Owner
Copy Link
Copy Source

Exception caused on line 175 when attempting to access _MapImages[i]. Probably an overflow issue, though no idea how that could happen. Should be looked into.

Exception caused on line 175 when attempting to access `_MapImages[i]`. Probably an overflow issue, though no idea how that could happen. Should be looked into.
ActualHorse added this to the v0.5 milestone 2026-04-17 14:58:35 -04:00
ActualHorse added the
Type
Bug
Priority
A
 labels 2026-04-17 14:58:35 -04:00
ActualHorse self-assigned this 2026-04-17 14:58:35 -04:00
ActualHorse pinned this 2026-04-17 14:59:15 -04:00
ActualHorse commented 2026-05-14 15:35:36 -04:00
Author
Owner
Copy Link
Copy Source

Added an extra array length check. The entire map loading code is very unstable, though, and a new method of adding to the download cache needs to be implemented. I'll keep this open until I'm sure this fix works, but someday I really need to revisit that section entirely.

Added an extra array length check. The entire map loading code is very unstable, though, and a new method of adding to the download cache needs to be implemented. I'll keep this open until I'm sure this fix works, but someday I really need to revisit that section entirely.
ActualHorse unpinned this 2026-05-14 15:41:45 -04:00
ActualHorse commented 2026-06-22 03:13:48 -04:00
Author
Owner
Copy Link
Copy Source

This seems to have been fixed well enough to close this. I do really want to rewrite that map loading code, though.

This seems to have been fixed well enough to close this. I do really want to rewrite that map loading code, though.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Priority
A
The priority is critical
Priority
B
The priority is high
Priority
C
The priority is medium
Priority
D
The priority is low
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Type
Breaking
Breaking change that won't be backward compatible
Type
Bug
Something is not working
Type
Documentation
Documentation changes
Type
Enhancement
Improve existing functionality
Type
Feature
New functionality
Type
Security
This is security issue
Type
Testing
Issue or pull request related to testing
No labels
Priority
A
Type
Bug
Milestone
No items
No Milestone v0.5
Projects
Clear projects
No projects
Assignees
Clear assignees
ActualHorse
No Assignees ActualHorse
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ActualHorse/CarmenSandiego#73